Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(klaviyo): add all traits to profile properties in track call #2572

Closed
wants to merge 3 commits into from
Closed

feat(klaviyo): add all traits to profile properties in track call #2572

wants to merge 3 commits into from

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

  • Add all traits to profile properties in track call

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from a team as code owners September 8, 2023 11:30
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3c328e) 86.85% compared to head (6496df1) 86.85%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2572   +/-   ##
========================================
  Coverage    86.85%   86.85%           
========================================
  Files          567      567           
  Lines        27964    27965    +1     
  Branches      6661     6664    +3     
========================================
+ Hits         24288    24289    +1     
  Misses        3342     3342           
  Partials       334      334
Files Changed Coverage Δ
src/v0/destinations/klaviyo/util.js 99.20% <ø> (ø)
src/v0/destinations/klaviyo/transform.js 91.08% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ujjwal-ab ujjwal-ab changed the base branch from develop to hotfix/sep.11 September 11, 2023 05:48
@ujjwal-ab ujjwal-ab requested review from sivashanmukh and a team as code owners September 11, 2023 05:48
@ujjwal-ab ujjwal-ab changed the base branch from hotfix/sep.11 to develop September 11, 2023 05:49
@ujjwal-ab
Copy link
Contributor Author

This is the PR to hotfix branch - #2581

@ujjwal-ab ujjwal-ab closed this Sep 11, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the klaviyo-profile-properties branch December 12, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishna2020 krishna2020 krishna2020 left review comments

@sauravlal15 sauravlal15 Awaiting requested review from sauravlal15 sauravlal15 is a code owner automatically assigned from rudderlabs/integrations

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujjwal-ab @krishna2020